-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Non-Toxic Water Stop Glowing #6608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venuska1117
changed the title
Mapping: Make Non-Toxic Water
Mapping: Make Non-Toxic Water Stop Glowing
Jul 2, 2024
github-actions
bot
added
Feature
Feature coder badge
Fix
Fix one bug, make ten more
labels
Jul 2, 2024
harryob
requested changes
Jul 2, 2024
harryob
requested changes
Jul 3, 2024
Venuska1117
changed the title
Mapping: Make Non-Toxic Water Stop Glowing
Code: Make Non-Toxic Water Stop Glowing
Jul 3, 2024
Venuska1117
changed the title
Code: Make Non-Toxic Water Stop Glowing
Make Non-Toxic Water Stop Glowing
Jul 3, 2024
harryob
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR make non-toxic water stop glowing, it kinda don't make sense, that on some maps, where water cover essential points is just GLOWING, now water will not glow unless its intended to be glowing.
Explain why it's good for the game
Water should not glow in darkness (unless its intended like on trijent dam)
Testing Photographs and Procedure
Changelog
🆑
fix: Make non-toxic water stop glowing.
/:cl: